camera-app

Code review comment for lp:~sergiusens/camera-app/click

  1. click
  2. Merge into trunk
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

201 + static bool click = (QString("@CLICK_MODE@") != QString("off"));

This is not reliable: cmake accepts also uppercase ON/OFF, and also lower and upper case true/false as arguments for enabling/disabling the arguments.

For instance, if I don't set CLICK_MODE to anything, the value will already be different:
static bool click = (QString("OFF") != QString("off"))

Can you set the value of another variable in CMakeLists.txt to some value depending on whether CLICK_MODE is enabled or disabled?

review: Needs Fixing

« Back to merge proposal