Merge lp:~sergiomeneses/ubuntu-manual-tests/gnome-terminal into lp:ubuntu-manual-tests

Proposed by Sergio Meneses
Status: Superseded
Proposed branch: lp:~sergiomeneses/ubuntu-manual-tests/gnome-terminal
Merge into: lp:ubuntu-manual-tests
Diff against target: 40 lines (+8/-8)
1 file modified
testcases/packages/1422_Gnome Terminal Tests (+8/-8)
To merge this branch: bzr merge lp:~sergiomeneses/ubuntu-manual-tests/gnome-terminal
Reviewer Review Type Date Requested Status
Nicholas Skaggs (community) Needs Fixing
Review via email: mp+151391@code.launchpad.net

This proposal has been superseded by a proposal from 2013-03-04.

To post a comment you must log in.
Revision history for this message
Javier López (javier-lopez) wrote :

I'd change the setup instructions to make it independent of Unity:

-<dt> Open Terminal using the dash, and typing 'terminal'</dt>
+<dt> Open the Terminal application</dt>

I'm not sure why you modified:

8 - <dt> Modify the colours to a different set</dt>
9 + <dt> Modify the "Colors" to a different set</dt>

It seems more natural to me, dt> Modify the colours to a different set</dt>, same applies for:

11 - <dt> Set a Background Image</dt>
12 + <dt> Set a "Background" Image</dt>

I agree with writing commands between ""

22 + <dt> Type "touch text1.txt"</dt>
23 + <dt> type "ls"</dt>

+ <dd>txt should now green?</dd> should be -> <dd>text1.txt is enlighten in green?</dd> ?

Greetings

Revision history for this message
Nicholas Skaggs (nskaggs) wrote :

> I'd change the setup instructions to make it independent of Unity:
>
> -<dt> Open Terminal using the dash, and typing 'terminal'</dt>
> +<dt> Open the Terminal application</dt>
>

I agree

> I'm not sure why you modified:
>
> 8 - <dt> Modify the colours to a different set</dt>
> 9 + <dt> Modify the "Colors" to a different set</dt>
>
> It seems more natural to me, dt> Modify the colours to a different set</dt>,
> same applies for:

Perhaps you can say something like:
<dt>Click on Edit, select Profiles, select Edit and select "Colors"</dt>
<dt>Using the options contained in the "Colors" tab modify the color palette, choosing some non-default colors or a different color scheme</dt>
<dd>The colors in your terminal match your modifications</dd>

What do you think?

>
> 11 - <dt> Set a Background Image</dt>
> 12 + <dt> Set a "Background" Image</dt>
>
> I agree with writing commands between ""

me too

>
> 22 + <dt> Type "touch text1.txt"</dt>
> 23 + <dt> type "ls"</dt>
>
> + <dd>txt should now green?</dd> should be -> <dd>text1.txt is enlighten in
> green?</dd> ?
>
> Greetings

Also, consider giving some more detail for these steps
<dt> Set a Background Image</dt>
<dt> Change the Zoom Level</dt>

review: Needs Fixing

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'testcases/packages/1422_Gnome Terminal Tests'
2--- testcases/packages/1422_Gnome Terminal Tests 2013-02-22 11:20:33 +0000
3+++ testcases/packages/1422_Gnome Terminal Tests 2013-03-03 16:00:28 +0000
4@@ -17,9 +17,9 @@
5 This test will check that terminal colors and zoom level can be changed
6 <dt> Open Terminal using the dash, and typing 'terminal'</dt>
7 <dt> Click on Edit, select Profiles, select Edit and select colours.</dt>
8- <dt> Modify the colours to a different set</dt>
9+ <dt> Modify the "Colors" to a different set</dt>
10 <dd>Colors change in terminal</dd>
11- <dt> Set a Background Image</dt>
12+ <dt> Set a "Background" Image</dt>
13 <dd>Terminal background changes</dd>
14 <dt> Change the Zoom Level</dt>
15 <dd>Did the zoom level change in terminal?</dd>
16@@ -29,19 +29,19 @@
17 <dl>
18 This test will check that terminal coloring is active
19 <dt> Open Terminal using the dash, and typing 'terminal'</dt>
20- <dt> Type in touch text1.txt</dt>
21- <dt> type in ls</dt>
22+ <dt> Type "touch text1.txt"</dt>
23+ <dt> type "ls"</dt>
24 <dt>txt is in black</dt>
25- <dt> Type in chmod 777 text1.txt</dt>
26- <dt> Type in ls</dt>
27- <dt>txt should now green?</dt>
28+ <dt> Type "chmod 777 text1.txt"</dt>
29+ <dt> Type "ls"</dt>
30+ <dd>txt should now green?</dd>
31 </dl>
32
33 Test-case name: gnometerminal/ter-004
34 <dl>
35 This test will check that the terminal tab launches succesfully
36 <dt> Open Terminal using the dash, and typing 'terminal'</dt>
37- <dt> Press Ctrl+Alt+T</dt>
38+ <dt> Press "Ctrl+Alt+T"</dt>
39 <dd>Is an instance of gnome-terminal with the title 'user@hostname: ~' opened, with the current directory set to the users home directory?</dd>
40 </dl>
41

Subscribers

People subscribed via source and target branches