Code review comment for ~sergiodj/ubuntu/+source/ubuntu-fan:fix-https-proxy-focal

On Monday, April 11 2022, Lucas Kanashiro wrote:

> Thanks for working on this Sergio! Since all tests are passing the behavior seems OK in the autopkgtest infrastructure.

Thanks for the review, Lucas.

> The only thing I think we might want to change here is the version
> string. Instead of using 0.12.14~20.04.1 I'd propose version
> 0.12.13ubuntu0.1. I understand you tried to avoid 'ubuntu' in the
> version string because this is a Ubuntu only package, but according to
> this security team wiki page [1], a native package should be appended
> by 'ubuntu0.1' in case we do not have the same version in more than
> one release (which is the case here). Usually, when I see "~xx.yy.z",
> where xx.yy is the Ubuntu release, this is a backport of a package in
> a newer series. WDYT?
>
> [1] https://wiki.ubuntu.com/SecurityTeam/UpdatePreparation

I was also unsure about the version to be used here. I looked at
ubuntu-fan's publishing history on LP and thought it made sense to use
"~xx.yy.z" as the suffix, but I also understand where you're coming from
when you suggest "ubuntu0.1".

I don't have a strong opinion regarding this, so I've gladly changed the
version to be 0.12.13ubuntu0.1 instead.

Thanks,

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14