Code review comment for ~sergiodj/ubuntu/+source/telegraf:update-impish-1.18.1

Revision history for this message
Bryce Harrington (bryce) wrote :

I drilled around a bit to try and understand what the fixed vulnerability actually was to suggest a changelog improvement, but found the CVE reports were too opaque, so no suggestion possible. The patch is a bit noisy but otherwise looks ok.

The packaging work all looks good, in particular the changes to repack-telegraf-with-vendor.sh.

I don't have an impish lxc container yet, so am not able to do my usual review checks. However, the ppa build looks good, and I trust your autopkgtest run.

So LGTM, +1.

review: Approve

« Back to merge proposal