Code review comment for ~sergiodj/ubuntu/+source/sssd:merge-2.7.1-2-kinetic

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

On Monday, June 20 2022, Andreas Hasenack wrote:

> Review: Approve

Thanks for the review, Andreas.

> I think you can merge these two commits. Usually in logical, but if you want to do it now on top of debian/sid that's also fine:
>
> commit d36036c652ab62d942eb2a8f8fa800fea6a78e3e
> Author: Sergio Durigan Junior <email address hidden>
> Date: Mon Feb 14 16:16:18 2022 -0500
>
> - Remember how architecture lists in debian/control work.
>
> commit 0d33597c0bec4a96959d9a770b7d2681707ab8e9
> Author: Sergio Durigan Junior <email address hidden>
> Date: Mon Feb 14 16:15:29 2022 -0500
>
> - d/control: Don't build sssd-tools on i386, now uninstallable due
> to added python3-{click,systemd} dependencies.
>

Done, thanks.

> DEP8 tests look good as well. I'm unsure what vorlon expects to see after the upload, since i386 won't build, and thus won't migrate.

Uploaded:

$ dput sssd_2.7.1-2ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/sssd/sssd_2.7.1-2ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/sssd/sssd_2.7.1-2ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Package includes an .orig.tar.gz file although the debian revision suggests
that it might not be required. Multiple uploads of the .orig.tar.gz may be
rejected by the upload queue management software.
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading sssd_2.7.1-2ubuntu1.dsc: done.
  Uploading sssd_2.7.1.orig.tar.gz: done.
  Uploading sssd_2.7.1.orig.tar.gz.asc: done.
  Uploading sssd_2.7.1-2ubuntu1.debian.tar.xz: done.
  Uploading sssd_2.7.1-2ubuntu1_source.buildinfo: done.
  Uploading sssd_2.7.1-2ubuntu1_source.changes: done.
Successfully uploaded packages.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

« Back to merge proposal