Code review comment for ~sergiodj/ubuntu/+source/sssd:bug1910611-update-apparmor-hirsute

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Thanks, I've checked the groovy MP as well by now.

Ack on the apparmor changes and in Hirsute the version is ok.

Thanks for the Debian MP as well.
There the piuparts test fail seems legit, not due to your changes but still a legit error as FYI.

You already mentioned the i386 build issues before. I guess you decided that since https://launchpad.net/ubuntu/+source/sssd/2.4.0-1ubuntu2 is b-wait on i386 as well it will be no-change and therefore ok.
I agree if that is the case, but otherwise please speak up.

OTOH i386 - see https://bugs.launchpad.net/ubuntu/+source/sssd/+bug/1904990
Maybe sooner or later i386 will resolve that way, but it does not have to stop/gate this upload.

review: Approve

« Back to merge proposal