Code review comment for ~sergiodj/ubuntu/+source/sssd:bug1910611-update-apparmor-focal

Sergio Durigan Junior (sergiodj) wrote :

On Tuesday, January 19 2021, Christian Ehrhardt  wrote:

> Review: Approve

Thanks, Christian.

> The changes LGTM and are rather trivial (no patches since it is in debian/*), ...
> I assume as part of the Hirsute MP you'll also do a Debian submission?

Yep; I already did yesterday:

https://salsa.debian.org/sssd-team/sssd/-/merge_requests/12

> BTW - we will also need a Groovy MP/upload - that built fine in your PPA, is there an MP for it?

Yes, I filed it at the same time yesterday:

https://code.launchpad.net/~sergiodj/ubuntu/+source/sssd/+git/sssd/+merge/396453

Curious that you didn't see it!

> Quite likely it is the same change there and an ultra fast-ack. So if you have the same change, don't bother (just for the process) to spin up that MP and wait for it.

Exactly, it's the same change.

> But be careful there as groovy sssd is 2.3.1-3ubuntu2 which already
> was wrong - IMHO that should have been 2.3.1-3ubuntu0.x all the
> time. Not too bad since hirsute is on 2.4 but still I couldn't look
> away while reviewing this :-)

Yeah; unfortunately I was the one who introduced this versioning error
on Groovy. I talked to Robie when I noticed, but he told me it was OK
and that I shouldn't worry about it. Anyway, as you say, I'm glad that
we're on 2.4 on hirsute.

Thanks!

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14

« Back to merge proposal