Ubuntu
rabbitmq-server package

Code review comment for ~sergiodj/ubuntu/+source/rabbitmq-server:bug1784757-fix-server-restart-hang

  1. Git
  2. lp:~sergiodj/ubuntu/+source/rabbitmq-server
  3. bug1784757-fix-server-restart-hang
  4. Merge into ubuntu/bionic-devel
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Moving "SyslogIdentifier=rabbitmq" around is just noise.
I'd understand if this is a conffile that would thereby match the next versions file.
But it is at /lib/systemd/system/rabbitmq-server.service so is there any need to move this line around?

I understand you have picked changes that later happened to the service file, but for the following changes I'm not sure if they are
a) needed to fix the immediate problem
b) don't have side effects that are unwanted in an SRU

+WorkingDirectory=/var/lib/rabbitmq
+Group=rabbitmq
+UMask=0027

Would you mind to re-vise the MP either explaining why those are needed OR dropping these changes for the SRU?

review: Needs Fixing

« Back to merge proposal