Code review comment for ~sergiodj/ubuntu/+source/qemu:lp2064914-windows-hangs-tsc-jammy

Revision history for this message
Bryce Harrington (bryce) wrote :

Autopkgtests vs. the PPA look ok:
  - qemu/1:6.2+dfsg-2ubuntu6.20~ppa1
    + ✅ qemu on jammy for amd64 @ 17.05.24 16:21:04 Log️ 🗒️
    + ✅ qemu on jammy for arm64 @ 12.05.24 22:39:07 Log️ 🗒️
    + ✅ qemu on jammy for armhf @ 10.05.24 02:46:05 Log️ 🗒️
    + ✅ qemu on jammy for ppc64el @ 15.05.24 20:22:17 Log️ 🗒️
    + ✅ qemu on jammy for s390x @ 14.05.24 16:41:06 Log️ 🗒️

The patch itself looks ok. Could there be any ABI concerns for tsc moving around in the struct? I'm assuming since qemu is not a library it isn't.

The SRU template needs filling out, but that's known already.

mfo has some review suggestions on the bug report worth considering prior to uploading.

review: Approve

« Back to merge proposal