Code review comment for ~sergiodj/ubuntu/+source/qemu:tcg-crash-mantic

On Wednesday, February 14 2024, Christian Ehrhardt  wrote:

> Review: Approve

Thanks for the review, Christian.

> Some trivial findings first:
>
> - patches are in debian/patches/ubuntu/ but the CL says - d/p/lp... should be - d/p/u/lp...

Ah, indeed. Thanks, I'll fix it.

> - some places mention kernel "6.13" while it is "6.3"

Doh. Fixed.

> - avoid some ambiguities by stating clearly that the kernel >=6.3 is in meant to be the one in the guest, otherwise some might think "so what, 6.3 isn't supported in jammy/mantic anyway" or similar

Done.

> I can see why you said Jammy backport might be more complex, there are
> probably plenty of changes to that code. My gut says that you'd be ok
> to backport quite some more changes (instead of only adapting those
> three patches) if you need it, but that is up to you as you see fit.

Yeah, I've been collecting the "adjacent" patches that will need to be
backported on Jammy. I think it should be fine at the end of the day.

> +1 on this one with the minor things fixed.

Thanks. I'll wait until I have the Jammy MP ready before I upload this
one.

> For the "where issues occur" in the SRU statement, the most important bit is that this seems purely in tcg code, so we can assume that HW-virt will not be affected ever.

ACK. I'm putting off writing the rest of the SRU template until I have
a clear picture of what the Jammy MP will be.

Cheers,

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14