Code review comment for ~sergiodj/ubuntu/+source/openssh:bug1877454-hangs-authorizedkeyscommand

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

So, like said before, if patch header is too ugly from upstream, I usually do the full (hopefully) DEP3 format:

----

Description: original patch description

 Minor or no description (if upstream lacks it)

Author:
Origin: <upstream|backport|vendor|other>, URL
Bug:
Bug-<Vendor>:
Forwarded:
Applied-Upstream:
Reviewed-by:
Last-Update:

----

And I remove MIME and/or mail headers from format-patch etc.

BUT this is MY preference, only mandatory thing is to follow guidelines (https://dep-team.pages.debian.net/deps/dep3/) mandatory things.

I also usually do:

debian/patches/lpXXXX-description.patch
debian/patches/lpXXXX-description.patch
debian/patches/lpXXXX-description.patch

for SRUs. If they all come from the same bug I would know.

Just showing options for you to consider (or not).

Cheers o/

« Back to merge proposal