Code review comment for ~sergiodj/ubuntu/+source/openssh:bug1877454-hangs-authorizedkeyscommand

Revision history for this message
Rafael David Tinoco (rafaeldtinoco) wrote :

# checklist for fixes
----------------------------
 [.] changelog entry correct:
 [.] targeted to correct codename
 [.] version number is correct
 [.] update-maintainer has been run before
 ----
 [-] changes forwarded upstream/debian (if appropriate)
 [.] patches match what was proposed upstream
 ----
 [.] patches correctly included in debian/patches/series?
 [.] patches have correct DEP3 metadata
     - suggestion: when upstream header is too ugly I usually
       rip things off and rely ONLY on DEP3 (other comment)
 ----
 [.] relying on PPA only for build check ?
 [.] if relying on PPA, did it install correctly ?
 ----
 [.] building it locally ?
 [.] if building locally, was source build good ?
 [.] if building locally, was binary build good ?
 ----
 [-] was autopkgtest tested ?
 ----
 [.] is this a SRU ?
 [.] if a SRU, does the public bug have a template ?
 [-] is this a bundle of fixes ?
 [.] is this a single fix ?
 ----
 [.] if single fix, was testcase provided ?
 [-] if single fix, and testcase provided, could I reproduce it ?
 [-] if single fix, and testcase provided, did it work ?
----------------------------
 [.] = ok
 [x] = not ok
 [?] = question
 [!] = note
 [-] = n/a
----------------------------
# files touched:

$ git log -2 -p | diffstat
 changelog | 14 +++++
 patches/authkeyscommand-deadlock-01.patch | 41 ++++++++++++++++
 patches/authkeyscommand-deadlock-02.patch | 74 ++++++++++++++++++++++++++++++
 patches/series | 2
 4 files changed, 131 insertions(+)

----------------------------
# files check:

----------------------------
# comments:

next comment

« Back to merge proposal