Code review comment for ~sergiodj/ubuntu/+source/openldap:MRE-2.5.17-jammy

Revision history for this message
Bryce Harrington (bryce) wrote :

LGTM, +1, presuming the autopkgtests pass.

I like the more detailed changelog personally, and if it saves some thinking time not to have to filter it, then that's a bonus.

I skimmed briefly through the upstream diff, nothing caught my eye. A healthy chunk of it is debug messaging, which is a good sign. There's an `mplay` command being added although that appears just for analysis/debugging (I can't tell if it gets installed but am guessing no.) The remainder does indeed look like bugfixes.

review: Approve

« Back to merge proposal