Code review comment for ~sergiodj/ubuntu/+source/openipmi:openipmi-merge-2.0.29-0.1

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Ok - I must have read over the MP description too quickly, but I'm glad we came to the same conclusion :-)

I think these three places should be updated to properly reflect the real summary of the remaining purpose of the Delta. And if you submit something upstream as usual link that in the patches header.

Patch Header
+Description: fix pkg-config files: pthread.pc does not exist in Ubuntu
375 + Forward-ported from 2.10.16-1.1, as it seems to have been dropped in
376 + Debian.

Changelog:
 Remaining changes:
9 + - debian/patches/fix_pthread_pkg_config.patch: fix pkg-config files:
10 + pthread.pc does not exist in Ubuntu. Thanks to Simon McVittie
11 + <email address hidden>. Closes #474087, LP #1311888.

Commit message:
    - debian/patches/fix_pthread_pkg_config.patch: fix pkg-config files:
      pthread.pc does not exist in Ubuntu. Thanks to Simon McVittie
      <email address hidden>. Closes #474087, LP #1311888.

+1 under the condition that this is done

review: Approve

« Back to merge proposal