Code review comment for ~sergiodj/ubuntu/+source/nut:fix-ftbfs-gcc-11

On Friday, August 13 2021, Sergio Durigan Junior wrote:

> On Friday, August 13 2021, Utkarsh Gupta wrote:
>
>> -> build-time tests aren't being run, why? :(
>> ```
>> ============================================================================
>> Testsuite summary for nut 2.7.4
>> ============================================================================
>> # TOTAL: 0
>> # PASS: 0
>> # SKIP: 0
>> # XFAIL: 0
>> # FAIL: 0
>> # XPASS: 0
>> # ERROR: 0
>> ============================================================================
>> ```
>
> I don't know offhand. As you can see from the logs "make check" is
> being properly invoked by the dh_auto_test target, and "make" is
> traversing the tree and calling "check" on the subdirs as expected, but
> for some reason all of them return with "Nothing to be done for
> 'check'."
>
> Looking into the "tests/" directory, we can see that there's not much
> there. I did find what looks like to be valid tests inside
> scripts/augeas/tests/test_nut.aug, but I don't know how they're supposed
> to be run.
>
> I checked that the same problem obviously happens on Debian, and I
> verified that the Fedora nut package doesn't run its tests during build
> time either. The next step would be to build a pristine upstream
> checkout and verify what happens there, I guess.

A few more interesting bits regarding this topic:

While looking at the dep8 tests from nut, I noticed that they were added
by the following commit (from Debian):

  commit f313323738fd5bf05cd49c0b80b1f21783e8602b
  Author: Laurent Bigonville <email address hidden>
  AuthorDate: Tue Jun 18 21:52:31 2013 +0200
  Commit: Laurent Bigonville <email address hidden>
  CommitDate: Tue Jun 18 21:52:31 2013 +0200

      Added dep-8-tests to improve QA (from Ubuntu, closes: #708130)

If we take a look at the actual tests inside d/t/, we can see that
there's a custom "d/t/test-nut.py", which came from Ubuntu. The file
looks a lot like what we have in the ~qa-regression-testing repository,
and I bet that's where it came from.

This all contributes to the theory that upstream doesn't have a very
comprehensive testsuite and for that reason we had to come up with our
own test script that were later incorporated into the official package.

Cheers,

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14