Code review comment for ~sergiodj/ubuntu/+source/nut:fix-ftbfs-gcc-11

On Friday, August 13 2021, Bryce Harrington wrote:

> Review: Approve

Thanks for the review.

> I'm curious why the new patch is numbered 0012 since there already is
> a different patch 0012 (and 0013), so seems like this should should be
> 0014. Fwiw, when Debian numbers their patches, I sometimes
> deliberately don't number the ubuntu ones; figure it distinguishes
> them and is less likely to get confused in future merges as the Debian
> patches change. However, patch naming is entirely personal
> preference.

Hm. I use "gbp pq" to manage patches (even with Ubuntu packages, which
don't use gbp), and I think that was a problem with how gbp calculated
this patch's number. That's a good point and I will manually rename it.

> I ran the testsuite but get weird errors about test dependencies:
> autopkgtest [03:52:23]: @@@@@@@@@@@@@@@@@@@@ summary
> nut FAIL badpkg
> blame: ./nut_2.7.4-13ubuntu5.dsc
> badpkg: Test dependencies are unsatisfiable. A common reason is that
> your testbed is out of date with respect to the archive, and you need
> to use a current testbed or run apt-get update or use -U.

Yeah, that was happening with me when I was running the tests using
schroot/lxd as the backend. When I switched to qemu (and enabled the
proposed pocket), the tests succeeded:

autopkgtest [16:12:52]: @@@@@@@@@@@@@@@@@@@@ summary
nut PASS

Anyway, thanks again. I will rename the patch, force-push the branch
and upload the package.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14