Merge ~sergiodj/ubuntu/+source/nfs-utils:bug1918141-service-file-adjustment-bionic into ubuntu/+source/nfs-utils:ubuntu/bionic-devel
Status: | Approved | ||||
---|---|---|---|---|---|
Approved by: | Sergio Durigan Junior | ||||
Approved revision: | 9ce0f6ba20eb7176371bd1ef3b9ced0dfb65a74b | ||||
Proposed branch: | ~sergiodj/ubuntu/+source/nfs-utils:bug1918141-service-file-adjustment-bionic | ||||
Merge into: | ubuntu/+source/nfs-utils:ubuntu/bionic-devel | ||||
Diff against target: |
198 lines (+170/-0) 4 files modified
debian/changelog (+11/-0) debian/patches/lp1918141-use-network-online-target-01.patch (+82/-0) debian/patches/lp1918141-use-network-online-target-02.patch (+75/-0) debian/patches/series (+2/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Utkarsh Gupta (community) | Approve | ||
Canonical Server Core Reviewers | Pending | ||
Review via email: mp+399749@code.launchpad.net |
Description of the change
This is a fix for bug 1918141 on bionic.
The issue here is that nfs-utils' systemd service file doesn't properly depend on network-
The bug is a bit tricky to reproduce, but I wrote an SRU template which contains detailed instructions on how to do that.
nfs-utils is really old on Ubuntu/Debian, but I was able to backport the proper fixes from the upstream git. You will notice that, although the changes made to the service file are simple, I opted to keep them separated in two patches. This is done to reflect the fact that the change was made in two upstream commits.
I've already uploaded the fix to hirsute:
https:/
You can find a PPA with the proposed fix here:
https:/
autopkgtest is still happy:
autopkgtest [17:55:05]: @@@@@@@
local-server-client PASS
Hiya,
Same comments as for MP#399747; copying here as well.
* Changelog:
- [✓] old content and logical tag match as expected
- [✓] changelog entry correct version and targeted codename
- [✓] changelog entries correct
- [✓] update-maintainer has been run
* New Delta: patches/ series
- [✓] patches match what was proposed upstream
- [✓] patches correctly included in debian/
- [?] patches have correct DEP3 metadata
Minor comment here:
The first patch in the header (line 46 of the diff) has "Applied-Upstream: 2.1.2-rc2", which seems to be missing in the second patch. Whilst a trivial nitpick, but since it was there in the first patch, it looks like it wasn't included in the second one intentionally, which would mean that it wasn't applied upstream - which is not the case. So for this + consistency reasons, could you add the same line in the second patch as well?
* Build/Test:
- [✓] build is ok
- [✓] verified PPA package installs/uninstalls
- [✓] autopkgtest against the PPA package passes
------- ------- ------- ------- ------- ------- ------- ---
All looks good, no blocker, so I'm going to approve this.
Besides, is it a Ubuntu-specific problem? Is not not affecting Debian? If it is, do you intend to forward this upstream? If it isn't, then ignore this part! :)