Code review comment for ~sergiodj/ubuntu/+source/net-snmp:merge-5.9.4-dfsg-1-noble

Revision history for this message
Bryce Harrington (bryce) wrote :

Changes carried correctly. Builds and tests all look good. Dropped change is present in the upstream git repository.

Only nitpick would be mentioning the version number where it was incorporated, i.e.:

  * Drop changes:
    - d/p/restore-support-for-long-dns-names.patch: Fix snmp requests
      for domains longer than 63 characters (LP #1998461)
      [ Incorporated in upstream release v5.9.4 ]

but that's style preference. Everything else LGTM, +1.

review: Approve

« Back to merge proposal