Code review comment for ~sergiodj/ubuntu/+source/libpcap:bug1865501-pkg-config

Thanks for identifying the configure/make changes needed to get this working Sergio.
The changelog looks well.
The build log has a few warnings, but not related to your change.
The PPA works as intended and shows no other impact.

I double checked the backported patches for potential side-effects but found none \o/.
Never the less the config changes make this way more noisy and intrusive than I'd have hoped :-/

In the review I learned that libpcap had another - non standard - way to provide this data already.
=> /usr/bin/pcap-config
This was retained going forward for compatibility:
Focal:
$ $ pcap-config --static --additional-libs --libs --cflags
-I/usr/include -lpcap
Bionic:
root@b:~# pcap-config --static --libs --cflags --additional-libs
-I/usr/include -lpcap
Bionic + PPA:
root@b:~# pcap-config --static --libs --cflags --additional-libs
-I/usr/include -lpcap

+1 for the review on this.

Let us see what the SRU Team thinks of "more intrusive than we hoped" + "there is a (non standard) alternative". Both arguments against the SRU, but no clear show stoppers.