Ubuntu
golang-1.16 package

Code review comment for ~sergiodj/ubuntu/+source/golang-1.16:fix-ftbfs-i386-bionic

  1. Git
  2. lp:~sergiodj/ubuntu/+source/golang-1.16
  3. fix-ftbfs-i386-bionic
  4. Merge into ubuntu/bionic-devel
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for the patch Sergio, appreciated!

Your solution (not setting GO386 variable in i386) seems to be the right way to go, and it indeed fixed the FTBFS as we can see in your PPA. I was thinking about the sse2-support runtime dependency, it would be better if we could keep the needed changes minimal (not needing that), but we could also hit the unlikely case where users would try to install it in a machine which does not support SSE2 instruction set.

I launched a container and installed the package, ran a simple script and it worked well.

I +1 the changes. Please, when uploading the package also include the previous changelog entry in the changes file.

review: Approve

« Back to merge proposal