Code review comment for ~sergiodj/ubuntu/+source/apache2:bug1969629-http2-empty-response-maxrequestsperchild-FOCAL

On Wednesday, April 27 2022, Bryce Harrington wrote:

> Review: Approve
>
> Reviewing the bug filed to launchpad and upstream, looks like a straightforward problem with a well-defined solution, which makes sense to SRU.
>
> I set up the three LXC containers and ran the test cases on all three
> releases, verified the error prints "BUG DETECTED", then installed the
> PPA and verified test case runs without exiting, as documented for the
> expected behavior.
>
> Code review of the patch looks ok, and the changes dropped compared with the upstream version of the patch makes sense.
>
> SRU text is quite well written; the test case is super
> paint-by-numbers and I really like how you suggested courses of action
> in case of regression in the where problems could occur section.
>
> Nothing at all to complain about. LVGTM, +1.

Thanks for the review, Bryce.

Uploaded:

$ dput apache2_2.4.41-4ubuntu3.11_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/apache2/apache2_2.4.41-4ubuntu3.11_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/apache2/apache2_2.4.41-4ubuntu3.11.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading apache2_2.4.41-4ubuntu3.11.dsc: done.
  Uploading apache2_2.4.41-4ubuntu3.11.debian.tar.xz: done.
  Uploading apache2_2.4.41-4ubuntu3.11_source.buildinfo: done.
  Uploading apache2_2.4.41-4ubuntu3.11_source.changes: done.
Successfully uploaded packages.

--
Sergio
GPG key ID: E92F D0B3 6B14 F1F4 D8E0 EB2F 106D A1C8 C3CB BF14