Ubuntu
apache2 package

Code review comment for ~sergiodj/ubuntu/+source/apache2:bug1969629-http2-empty-response-maxrequestsperchild-FOCAL

  1. Git
  2. lp:~sergiodj/ubuntu/+source/apache2
  3. bug1969629-http2-empty-response-maxrequestsperchild-FOCAL
  4. Merge into ubuntu/focal-devel
Revision history for this message
Bryce Harrington (bryce) wrote :

Reviewing the bug filed to launchpad and upstream, looks like a straightforward problem with a well-defined solution, which makes sense to SRU.

I set up the three LXC containers and ran the test cases on all three releases, verified the error prints "BUG DETECTED", then installed the PPA and verified test case runs without exiting, as documented for the expected behavior.

Code review of the patch looks ok, and the changes dropped compared with the upstream version of the patch makes sense.

SRU text is quite well written; the test case is super paint-by-numbers and I really like how you suggested courses of action in case of regression in the where problems could occur section.

Nothing at all to complain about. LVGTM, +1.

review: Approve

« Back to merge proposal