Code review comment for ~sergiodj/ubuntu-docker-images/+git/loki:promtail-config

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Hi Sergio, thanks for the MP!

The new configuration file contains a snap specific env var at

positions:
  filename: ${SNAP_COMMON}/positions.yaml

As you did with the loki.yaml file, that sed substitution should also apply here.

Other than that, this LGTM!

review: Needs Information

« Back to merge proposal