Code review comment for ~sergiodj/ubuntu-docker-images/+git/grafana:8.1-21.10

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Hi Sergio,

The changes LGTM.

I did build and run the image, and can confirm Grafana starts and is available in port 3000.

I did see one odd thing during startup though: the logs show the following error:

EROR[08-26|12:33:37] Failed to read plugin provisioning files from directory logger=provisioning.plugins path=/etc/grafana/provisioning/plugins error="open /etc/grafana/provisioning/plugins: no such file or directory"

While I understand this could (should?) be set as a volume by users in case they want to load their custom configurations, should we create that directory for a clean startup otherwise?

Also, see https://github.com/grafana/grafana/pull/29570

review: Needs Information

« Back to merge proposal