Merge lp:~sergio-incaser/account-payment/v7.0-account_payment_extension into lp:~account-payment-team/account-payment/7.0

Proposed by Sergio Teruel on 2013-11-20
Status: Merged
Merged at revision: 105
Proposed branch: lp:~sergio-incaser/account-payment/v7.0-account_payment_extension
Merge into: lp:~account-payment-team/account-payment/7.0
Diff against target: 12 lines (+1/-1)
1 file modified
account_payment_extension/wizard/account_payment_order.py (+1/-1)
To merge this branch: bzr merge lp:~sergio-incaser/account-payment/v7.0-account_payment_extension
Reviewer Review Type Date Requested Status
xavi (community) Approve on 2013-12-10
Lorenzo Battistini (community) code review Approve on 2013-11-20
Pedro Manuel Baeza 2013-11-20 Approve on 2013-11-20
Review via email: mp+195946@code.launchpad.net

Description of the change

[FIX] account_payment_extension. Selects only invoices with due date less or equal than the date entered

To post a comment you must log in.
Pedro Manuel Baeza (pedro.baeza) wrote :

Hi, Sergio, thank you very much for the fix. Indeed, the behaviour was confusing, so let's change to the one you propose.

I changed the description of the change to reflect exactly the fix.

Regards.

review: Approve
Sergio Teruel (sergio-incaser) wrote :

Ok. Perfect...
They are the first merge I do, so I'm a bit lost ...

Thanks..

2013/11/20 Pedro Manuel Baeza <email address hidden>

> The proposal to merge
> lp:~sergio-incaser/account-payment/v7.0-account_payment_extension into
> lp:account-payment/7.0 has been updated.
>
> Description changed to:
>
> [FIX] account_payment_extension. Selects only invoices with due date less
> or equal than the date entered
>
> For more details, see:
>
> https://code.launchpad.net/~sergio-incaser/account-payment/v7.0-account_payment_extension/+merge/195946
> --
>
> https://code.launchpad.net/~sergio-incaser/account-payment/v7.0-account_payment_extension/+merge/195946
> You are the owner of
> lp:~sergio-incaser/account-payment/v7.0-account_payment_extension.
>

--

*Sergio Teruel Albert*

*C/ Torres Quevedo 6*
*12530 Burriana (Castell├│n)*
*Tel. 964 05 46 57 *
*<email address hidden>* <email address hidden>* <email address hidden>*

review: Approve (code review)
xavi (xgilest) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'account_payment_extension/wizard/account_payment_order.py'
2--- account_payment_extension/wizard/account_payment_order.py 2013-05-17 13:28:00 +0000
3+++ account_payment_extension/wizard/account_payment_order.py 2013-11-20 11:27:00 +0000
4@@ -98,7 +98,7 @@
5 if payment.mode:
6 domain += [ ('payment_type','=',payment.mode.type.id) ]
7
8- domain += ['|',('date_maturity','<',search_due_date),('date_maturity','=',False)]
9+ domain += ['|',('date_maturity','<=',search_due_date),('date_maturity','=',False)]
10 line_ids = line_obj.search(cr, uid, domain, order='date_maturity', context=context)
11
12 selected_ids = []