Since you are touching the code anyway, in diff lines 127,141
s/record/records.
Please move all local var decls to the block start (in this case
function start).
The extra indentation makes a lot of lines to go over the line
length limit. I am not sure if and how we'd want to fix this
(especially for 2.1), please get a second opinion. IMVHO, we should
leave it as-is for 2.0 and extract new function in 2.1.
Since you are touching the code anyway, in diff lines 127,141 records.
s/record/
Please move all local var decls to the block start (in this case
function start).
The extra indentation makes a lot of lines to go over the line
length limit. I am not sure if and how we'd want to fix this
(especially for 2.1), please get a second opinion. IMVHO, we should
leave it as-is for 2.0 and extract new function in 2.1.