Code review comment for lp:~sergei.glushchenko/percona-xtrabackup/bug733651_mycnf_opt-1.6

Alexey Kopytov (akopytov) wrote :

Sergei,

On 27.01.12 10:14, Sergei Glushchenko wrote:
> @@ -2192,7 +2202,35 @@
> }
>
>
> +# has_option return whether the config has an option with the given name
> +# Parameters:
> +# config_ref a reference to a config data
> +# group option group name
> +# option_name name of the option
> +# Return value:
> +# true if option exists, otherwise false
> #
> +sub has_option {
> + my $config_ref = shift;
> + my $group = shift;
> + my $option_name = shift;
> + my $default_value = shift;
> + my $group_hash_ref;
> + my $option_value;

You don't seem to be using $default_value and $option_value. Otherwise
looks good to me.

« Back to merge proposal