Code review comment for lp:~sergei.glushchenko/percona-xtrabackup/BT30559-kill-long-selects

Revision history for this message
Alexey Kopytov (akopytov) wrote :

Sergei,

Thanks. I would like the following things in user-visible text to be fixed before it is merged. Otherwise approved.

   - s/enales/enables/
   - s/"before start "FLUSH TABLE WITH READ LOCK"/before FLUSH TABLES
     WITH READ LOCK is started by innobackupex/
   - s/time in seconds to wait moment when there are no.../time in
     seconds to wait until there are no.../
   - s/This option specifies number of seconds innobackupex will wait
     after it issued the global lock and before it start to kill
     queries/This option specifies the number of seconds innobackupex
     waits between starting FLUSH TABLES WITH READ LOCK and killing
     those queries that block it./
   - s/which means no query killing/which means innobackupex will not
     attempt to kill any queries/
   - s/If value is not 0, innobackupex will wait not longer than
     specified amount of seconds for a good moment to issue the global
     lock. If no good moment being catched, innobackupex will bail out./
     This option specifies time in seconds that innobackupex should
     wait for queries that would block FTWRL before running it. If
     there are still such queries when the timeout expires,
     innobackupex terminates with an error.
   - s/Default is 0 which means no waiting for a good moment, just issue
     the global lock mandatory./Default is 0, in which case
     innobackupex does not wait for queries to complete and starts FTWRL
     immediately./
   - s/This option specifes the minimum age of a query to be considered as
     "long running" and potentially a blocker of the global lock. Such a
     queries will prevent the global lock from being issued (see
     --lock-wait-timeout).This option does not have any meaning if
     --lock-wait-timeout=0./
      This option specifies the query run time threshold which is used by
     innobackupex to detect long-running queries with a non-zero value
     of --lock-wait-timeout. FTWRL is not started until such
     long-running queries exist. This option has no effect if
     --lock-wait-timeout is 0.

review: Approve

« Back to merge proposal