Code review comment for lp:~sergei.glushchenko/percona-xtrabackup/BT-26901-2.0
Revision history for this message
| Laurynas Biveinis (laurynas-biveinis) wrote | # |
review:
Needs Fixing
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
What is the purpose of chunk at 23-40?
That chunk and the innobackupex change seem to fix some other bug, not a regression from 932623. Can you link that bug, or if there is none, report it?
Please introduce a wrapper around #ifdef ... == 0 #else ... trx_sys_sys_space ... #endif.
Why does the testcase skip in case of !XtraDB? I think this test applies to all InnoDB flavors.
Is it necessary to grep innobackupex output for full_backup_dir? IIRC other testcases dont't do this. Likewise for inc_backup_dir.
I am not sure if the testcase should be all the way to table checksum checking with restored data, or the steps up to the crashing point are necessary. In this particular instance I'd err on the side of more testing.