Code review comment for lp:~sergei.glushchenko/percona-xtrabackup/20-bug856400

Revision history for this message
Sergei Glushchenko (sergei.glushchenko) wrote :

Alexey,

Indeed, I forgot to cleanup things like xtrabackup_apply_deltas(TRUE).

What if I have MyISAM table named test_table and innodb_data_file_path=test_table.MYD:10M:autoextend? In this case incorrect backup will be taken. In fact I think one should also add "./" to innodb_data_file_path component to avoid disambiguations. So it can be considered as an attempt to workaround (now officially reported) bug https://bugs.launchpad.net/percona-xtrabackup/+bug/1169726.

s/strcpy/sprintf/ is really an accident, sorry :)

« Back to merge proposal