Merge lp:~sergei.glushchenko/percona-xtrabackup/2.2-xb-bug1239728 into lp:percona-xtrabackup/2.2

Proposed by Sergei Glushchenko
Status: Merged
Approved by: Alexey Kopytov
Approved revision: no longer in the source branch.
Merged at revision: 4883
Proposed branch: lp:~sergei.glushchenko/percona-xtrabackup/2.2-xb-bug1239728
Merge into: lp:percona-xtrabackup/2.2
Diff against target: 27 lines (+7/-0)
1 file modified
xtrabackup/innobackupex (+7/-0)
To merge this branch: bzr merge lp:~sergei.glushchenko/percona-xtrabackup/2.2-xb-bug1239728
Reviewer Review Type Date Requested Status
Alexey Kopytov (community) Approve
Review via email: mp+192220@code.launchpad.net

Description of the change

Added synchronization between child thread which supposed to kill queries and parent thread, so parent will not kill child until last finished initialization.

http://jenkins.percona.com/job/percona-xtrabackup-2.2-param/23/

To post a comment you must log in.
Revision history for this message
Alexey Kopytov (akopytov) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'xtrabackup/innobackupex'
--- xtrabackup/innobackupex 2013-09-26 06:26:18 +0000
+++ xtrabackup/innobackupex 2013-10-22 18:53:17 +0000
@@ -3307,6 +3307,7 @@
3307 local $SIG{HUP} = sub { $end = 1 };3307 local $SIG{HUP} = sub { $end = 1 };
33083308
3309 $pcon->{dbh}->{InactiveDestroy} = 1;3309 $pcon->{dbh}->{InactiveDestroy} = 1;
3310 kill('USR1', $innobackupex_pid);
33103311
3311 sleep($kill_timeout);3312 sleep($kill_timeout);
33123313
@@ -3348,9 +3349,15 @@
3348 $now = current_time();3349 $now = current_time();
3349 print STDERR "$now $prefix Starting to lock all tables...\n";3350 print STDERR "$now $prefix Starting to lock all tables...\n";
33503351
3352 my $query_killer_init = 0;
3353
3351 # start query killer process3354 # start query killer process
3352 if ($option_kill_long_queries_timeout) {3355 if ($option_kill_long_queries_timeout) {
3356 local $SIG{'USR1'} = sub { $query_killer_init = 1 };
3353 start_query_killer($option_kill_long_queries_timeout, $con);3357 start_query_killer($option_kill_long_queries_timeout, $con);
3358 while (!$query_killer_init) {
3359 usleep(1);
3360 }
3354 }3361 }
3355 if (compare_versions($mysql_server_version, '4.0.22') == 03362 if (compare_versions($mysql_server_version, '4.0.22') == 0
3356 || compare_versions($mysql_server_version, '4.1.7') == 0) {3363 || compare_versions($mysql_server_version, '4.1.7') == 0) {

Subscribers

People subscribed via source and target branches