Code review comment for lp:~sergei.glushchenko/percona-server/ps56-univ-log-archive
Revision history for this message
| Sergei Glushchenko (sergei.glushchenko) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
I understand the reasoning for keeping ondisk format unchanged, but I think proposed algorithm can be made simpler.
Lets suppose we store only file number, but not the offset (we use both current 4-byte file_no and offset for it). After restart, we can read archived file number and archived lsn from checkpoint. So no need to iterate files in directory!. From archived file header we can read start lsn for this file and get offset by using subtraction.
Does it look good?