Merge lp:~sergei.glushchenko/percona-server/mysqlbinlog-stdin-5.1 into lp:percona-server/5.1
Proposed by
Sergei Glushchenko
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Alexey Kopytov | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 429 | ||||
Proposed branch: | lp:~sergei.glushchenko/percona-server/mysqlbinlog-stdin-5.1 | ||||
Merge into: | lp:percona-server/5.1 | ||||
Diff against target: |
97 lines (+61/-2) 3 files modified
Percona-Server/client/mysqlbinlog.cc (+3/-2) Percona-Server/mysql-test/r/percona_bug933969.result (+16/-0) Percona-Server/mysql-test/t/percona_bug933969.test (+42/-0) |
||||
To merge this branch: | bzr merge lp:~sergei.glushchenko/percona-server/mysqlbinlog-stdin-5.1 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov (community) | Approve | ||
Review via email: mp+93810@code.launchpad.net |
Description of the change
Bug #933969: mysqlbinlog doesn't accept stdin
mysqlbinlog can't handle stdin when "|" used.
mysqlbinlog fails after making an attempt to execute seek on pipe handle.
Buffered read used in mysqlbinlog and it's possible to seek inside buffer
window. But in check_header routine seek(0) made before any read
operation, when buffer is empty. Due to it actual seek is performed.
Solution is to avoid seek(0) operation in check_header before any read is
performed, e.g. when we are at the beginning of the file.
To post a comment you must log in.
Jenkins build: jenkins. percona. com/view/ Percona% 20Server% 205.1/job/ percona- server- 5.1-param/ 258/
http://