Code review comment for lp:~sergei.glushchenko/percona-server/ST28246-bug1092593-5.1

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

I suggest different wordings for the testcase comments:

    - "Test the slave running with --log-slave-updates first, then
      restarting without this option, and crashing. With the bug
      present, crash recovery will restore binlog position that was
      written before the restart and thus is outdated."

    - "InnoDB and binlog are operating using two-phase commit protocol
      at slave, both "prepare" and "commit" points are updated with
      binlog coordinates"

    - "Now InnoDB is operating using one-phase commit protocol at
      slave. Before the fix, only the "commit" point was being
      updated."

    - "Kill the slave to trigger binlog position recovery from
      "prepare" point on the next startup."

    - "This will fail if the bug is present: the binlog coordinates
      at "prepare" point have been last updated before the server
      restart. After the restart the slave was running without
      --log-slave-updates, skipping the "prepare" point update. Thus
      on startup slave will read the obsolete position and fail.
      After the fix the "prepare" point will be current.

Since this is a comment-only change, no Jenkins run is necessary. Just a local run of this single testcase.

review: Needs Fixing

« Back to merge proposal