Merge lp:~sergei.glushchenko/percona-server/5.5-ps-bug1334719 into lp:percona-server/5.5

[Sergei Glushchenko]

    Bug 1334719: Valgrind: memory leak in MTR percona_secure_file_priv_noarg

    Release memory allocated for opt_secure_file_priv in my_getopt.c
    with my_strdup.

    Tested locally with ./mtr percona_secure_file_priv_noarg secure_file_priv --valgrind

http://jenkins.percona.com/view/PS%205.5/job/percona-server-5.5-param/1044/

[Laurynas Biveinis (laurynas-biveinis)]

review: Approve

=== modified file 'sql/mysqld.cc'
--- sql/mysqld.cc	2014-08-22 09:58:37 +0000
+++ sql/mysqld.cc	2014-09-01 14:53:56 +0000
@@ -432,7 +432,7 @@
 my_bool relay_log_recovery;
 my_bool opt_sync_frm, opt_allow_suspicious_udfs;
 my_bool opt_secure_auth= 0;
-char* opt_secure_file_priv;
+char* opt_secure_file_priv= NULL;
 my_bool opt_secure_file_priv_noarg= FALSE;
 my_bool opt_log_slow_admin_statements= 0;
 my_bool opt_log_slow_slave_statements= 0;
@@ -7521,6 +7521,7 @@
   case OPT_SECURE_FILE_PRIV:
     if (argument == NULL)
     {
+      my_free(opt_secure_file_priv);
       opt_secure_file_priv_noarg= TRUE;
       opt_secure_file_priv= my_strdup("ON", MYF(0));
     }