Merge lp:~sergei.glushchenko/percona-pam-for-mysql/rem-deps into lp:percona-pam-for-mysql

[Sergei Glushchenko]

Bug 929333
Unnecessary dependencies in dialog.so and auth_pam.so
Both dialog.so and auth_pam.so are dependent of libmysqlclient and
libpam. However libmysqlclient is not used in auth_pam.so and libpam is
not used in dialog.so

Build scripts were changed. dialog.so was linked against libmysqlclient
while auth_pam.so was linked against libpam.

[Laurynas Biveinis (laurynas-biveinis)]

LGTM, thank you.

review: Approve

=== modified file 'configure.ac'
--- configure.ac	2012-02-01 15:15:19 +0000
+++ configure.ac	2012-02-09 06:27:17 +0000
@@ -42,11 +42,11 @@
       [AC_MSG_ERROR([Unable to find mysql_config. Please install or specify.])])
 
 # Checks for libraries.
-AC_CHECK_LIB([pam], [pam_start], ,
+AC_CHECK_LIB([pam], [pam_start], [AUTH_PAM_LIBS="$AUTH_PAM_LIBS -lpam"],
     AC_MSG_ERROR(
         [Unable to find PAM. Please install the PAM development libraries])
 )
-AC_CHECK_LIB([mysqlclient], [mysql_init], ,
+AC_CHECK_LIB([mysqlclient], [mysql_init], [DIALOG_LIBS="$DIALOG_LIBS -lmysqlclient"],
     AC_MSG_ERROR(
         [Unable to find libmysqlclient. Please install the mysql development libraries])
 )
@@ -78,6 +78,9 @@
 
 AC_SUBST([REVISION])
 
+AC_SUBST([AUTH_PAM_LIBS])
+AC_SUBST([DIALOG_LIBS])
+
 # Output files
 AC_CONFIG_FILES([Makefile
                  src/Makefile
 
=== modified file 'src/Makefile.am'
--- src/Makefile.am	2012-02-01 14:42:43 +0000
+++ src/Makefile.am	2012-02-09 06:27:17 +0000
@@ -22,7 +22,7 @@
 
 auth_pam_la_SOURCES = auth_pam.c lib_auth_pam_client.h lib_auth_pam_client.c
 auth_pam_la_CPPFLAGS = $(plugin_CPPFLAGS)
-auth_pam_la_LDFLAGS = $(plugin_LDFLAGS)
+auth_pam_la_LDFLAGS = $(plugin_LDFLAGS) $(AUTH_PAM_LIBS)
 
 test_auth_pam_client_la_SOURCES = test_auth_pam_client.c \
 	lib_auth_pam_client.h lib_auth_pam_client.c
@@ -30,4 +30,4 @@
 
 dialog_la_SOURCES = dialog.c
 dialog_la_CPPFLAGS = $(plugin_CPPFLAGS)
-dialog_la_LDFLAGS = $(plugin_LDFLAGS)
+dialog_la_LDFLAGS = $(plugin_LDFLAGS) $(DIALOG_LIBS)