Code review comment for lp:~serge-hallyn/ubuntu/maverick/etherboot/usrshareqemu

> etherboot (5.4.4-1ubuntu1.1) maverick; urgency=low

Wrong version number for an upload to the current devel release; this version number is only appropriate for an SRU, which this is not.

Also, this version number has already been used before, in Dustin's SRU attempt which was later rejected from lucid-proposed; you would need to use a distinct version number in any case.

=== modified file 'debian/rules'
--- debian/rules 2010-01-02 07:25:53 +0000
+++ debian/rules 2010-08-13 01:04:41 +0000
@@ -31,6 +31,8 @@
        cp src/bin/rtl8139.zrom
+$(CURDIR)/debian/kvm-pxe/usr/share/kvm/pxe-rtl8139.bin
        cp src/bin/virtio-net.zrom
+$(CURDIR)/debian/kvm-pxe/usr/share/kvm/pxe-virtio.bin
        chmod -x $(CURDIR)/debian/kvm-pxe/usr/share/kvm/*
+ mkdir -p $(CURDIR)/debian/kvm-pxe/usr/share/qemu
+ cd $(CURDIR)/debian/kvm-pxe/usr/share/qemu; ln -s ../kvm/*.bin .; cd -
        mkdir -p debian/etherboot/usr/share/doc/etherboot

        cp -a contrib debian/etherboot/usr/share/doc/etherboot

This is identical to the change previously uploaded to lucid-proposed, which Martin Pitt rejected saying that there was "a reported regression". Since Martin didn't provide a reference for this regression, we'll need to get him to comment on this.