Code review comment for lp:~serge-hallyn/ubuntu-test-cases/server-lxc2

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Quoting Stéphane Graber (<email address hidden>):
> I'm not seeing anything obviously wrong, just a few notes:
> - I just sent a patch upstream to drop the need for autoconf pre-processing of api_test.py which should let you drop the extra build from the test.

Unfortunately that isn't yet in our package :) But I've left a comment
to remind us of that.

> - Might be worth running pyflakes and pep8 against all the python scripts, I noticed some things that aren't PEP-8 compliant.
> - When installing lxc in the container, you can easily avoid the policy-rc.d + rm by simply creating /etc/init/lxc.override with "manual" as content before installing lxc. This will prevent upstart from starting the lxc job and any job depending on it.

Awesome, that leaves PkgSetup() looking much nicer, thanks.

-serge

« Back to merge proposal