Code review comment for lp:~serge-hallyn/ubuntu-test-cases/server-lxc2

Revision history for this message
Stéphane Graber (stgraber) wrote :

I'm not seeing anything obviously wrong, just a few notes:
 - I just sent a patch upstream to drop the need for autoconf pre-processing of api_test.py which should let you drop the extra build from the test.
 - Might be worth running pyflakes and pep8 against all the python scripts, I noticed some things that aren't PEP-8 compliant.
 - When installing lxc in the container, you can easily avoid the policy-rc.d + rm by simply creating /etc/init/lxc.override with "manual" as content before installing lxc. This will prevent upstart from starting the lxc job and any job depending on it.

« Back to merge proposal