Code review comment for lp:~serge-hallyn/serverguide/lxc-trusty-update

Revision history for this message
Doug Smythies (dsmythies) wrote :

Serge, thanks for your work on this. In the end, I am not a subject matter expert on this, so can only check some things.

Currently, the code does not validate. It must validate. Please use this as a quick how to reference:

https://wiki.ubuntu.com/DocumentationTeam/SystemDocumentation/UbuntuServerGuide

Here is a cut and paste from my computer:

doug@s15:~/sguide-1404/saucy$ bzr pull lp:serverguide
Enter passphrase for key '/home/doug/.ssh/id_rsa':
No revisions or tags to pull.
doug@s15:~/sguide-1404/saucy$ scripts/validate.sh serverguide/C/serverguide.xml
 --Validating serverguide/C/serverguide.xml ...
doug@s15:~/sguide-1404/saucy$ bzr merge lp:~serge-hallyn/serverguide/lxc-trusty-update
Enter passphrase for key '/home/doug/.ssh/id_rsa':
 M serverguide/C/virtualization.xml
All changes applied successfully.
doug@s15:~/sguide-1404/saucy$ scripts/validate.sh serverguide/C/serverguide.xml
 --Validating serverguide/C/serverguide.xml ...
virtualization.xml:2168: element xref: validity error : IDREF attribute linkend references an unknown ID "lxc-conf-other"
virtualization.xml:2382: element xref: validity error : IDREF attribute linkend references an unknown ID "lxc-conf-other"
Document serverguide/C/serverguide.xml does not validate

review: Needs Fixing

« Back to merge proposal