Code review comment for lp:~sense/notify-osd/fix-465801
Revision history for this message
| Robert Collins (lifeless) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
1b1ed1a
(Get the code!)
Looks sane to me, though I'm not a notify-OSD committer.
It would be good to factor out the logfile name selection and add a test
to demonstrate that your needs are met, but if you don't feel like
doing that, perhaps a comment [so that this doesn't get changed
incorrectly in the future] would be useful.
-Rob