Code review comment for lp:~senan/ubuntu-autopilot-tests/DiskUsageAnalyser

Revision history for this message
Dan Chapman  (dpniel) wrote :

Senan
On 05/02/14 16:41, Prabhendu V Senan wrote:
>>
>>
>> I've already implemented the code for removing auto-completion
>>
>> editBox = self.app.select_single('GtkFileChooserEntry')
>> #self.keyboard.focused_type(editBox)
>> self.assertThat(editBox.is_focus,Equals(True))
>> self.keyboard.type(key_input)
>> sleep(2)
>> self.keyboard.press_and_release('Delete')
>> self.assertThat(editBox.text,Equals(key_input))
>>
>> I am not sure why the auto-completion box is still showing even after this.. can you please check that. Also I didnt understand assert /Home in pathbar.PathBar in filechooserDlg or after clicking _open button
This can be simple resolved by removing the trailing / so '/home/'
becomes '/home'. For the path bar it would be ideal to assert we are in
the required directory either by the pathbars label or stock icon
properties to determin we are in the correct place before clicking open
>> 3) With regards to checking the ring and bar charts igf you look in vis their
>> visible property is always set to true even when not visible, so asserting
>> it's visible isn't gaining us anything. We should try and find another way to
>> assert they are visible
> I couldn't find any other propery to validate in this case..:( .. need your help
I will need to investigate this further as it does seem quite tricky

« Back to merge proposal