Code review comment for lp:~senan/ubuntu-autopilot-tests/DiskUsageAnalyser

Revision history for this message
Dan Chapman  (dpniel) wrote :

This is really making progress now, nice work. THere is just a couple more things that need tweaking,

1) The test script formatting is a little whacky, it looks like you have been using 8 space tab characters for part of it, ideally you should set this to 4 spaces.

2) When entering /home/ in the file chooser dialog it doesn't seem to close beacause of the autocompletion box being open, you need to make sure after typing either press 'Delete' so the autocompletion box closes or double click the _open button. It would also be good to assert that the PathBar in the dialog is in the /Home directory.

3) With regards to checking the ring and bar charts igf you look in vis their visible property is always set to true even when not visible, so asserting it's visible isn't gaining us anything. We should try and find another way to assert they are visible

If you can make these changes then i think we are nearly there :-) Nice One!

review: Needs Fixing

« Back to merge proposal