Merge lp:~semiosis/ubuntu/precise/glusterfs/fix-for-876648 into lp:ubuntu/precise/glusterfs

Proposed by Louis Zuckerman
Status: Needs review
Proposed branch: lp:~semiosis/ubuntu/precise/glusterfs/fix-for-876648
Merge into: lp:ubuntu/precise/glusterfs
Diff against target: 68 lines (+29/-1)
5 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/glusterfs-server.mounting-glusterfs.upstart (+7/-0)
debian/glusterfs-server.upstart (+10/-0)
debian/rules (+3/-0)
To merge this branch: bzr merge lp:~semiosis/ubuntu/precise/glusterfs/fix-for-876648
Reviewer Review Type Date Requested Status
Clint Byrum (community) Needs Fixing
Review via email: mp+90587@code.launchpad.net

Description of the change

added two upstart jobs to glusterfs-server package:
- glusterfs-server.conf: the glusterd management daemon (replaces debian initscript)
- mounting-glusterfs.conf: blocks mounting glusterfs filesystems until glusterfs-server is started

To post a comment you must log in.
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Wow this is great, thanks so much for submitting.

One nit-pick.. you need to run 'update-maintainer' in the package root so that the Maintainer is changed to the ubuntu developers, since we have patched the package. Just run that, and bzr commit/push, and it will be ready to be sponsored.

review: Needs Fixing
22. By Louis Zuckerman

updated maintaner to ubuntu developers

Revision history for this message
Louis Zuckerman (semiosis) wrote :

> Wow this is great, thanks so much for submitting.
>
> One nit-pick.. you need to run 'update-maintainer' in the package root so that
> the Maintainer is changed to the ubuntu developers, since we have patched the
> package. Just run that, and bzr commit/push, and it will be ready to be
> sponsored.

Done. I also fixed a typo in the mounting-glusterfs description.

23. By Louis Zuckerman

fixed a typo in the mounting-glusterfs description

Unmerged revisions

23. By Louis Zuckerman

fixed a typo in the mounting-glusterfs description

22. By Louis Zuckerman

updated maintaner to ubuntu developers

21. By Louis Zuckerman

Added Ubuntu upstart jobs providing support for local glusterfs mounts
(LP: #876648)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2012-01-07 14:19:57 +0000
+++ debian/changelog 2012-01-29 12:55:28 +0000
@@ -1,3 +1,10 @@
1glusterfs (3.2.5-1ubuntu1) precise; urgency=low
2
3 * Added Ubuntu upstart jobs providing support for local glusterfs mounts
4 (LP: #876648)
5
6 -- Louis Zuckerman <me@louiszuckerman.com> Sat, 28 Jan 2012 15:32:55 -0500
7
1glusterfs (3.2.5-1) unstable; urgency=low8glusterfs (3.2.5-1) unstable; urgency=low
29
3 [ Louis Zuckerman ]10 [ Louis Zuckerman ]
411
=== modified file 'debian/control'
--- debian/control 2011-11-05 11:33:56 +0000
+++ debian/control 2012-01-29 12:55:28 +0000
@@ -1,7 +1,8 @@
1Source: glusterfs1Source: glusterfs
2Section: admin2Section: admin
3Priority: optional3Priority: optional
4Maintainer: Patrick Matthäi <pmatthaei@debian.org>4Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
5XSBC-Original-Maintainer: Patrick Matthäi <pmatthaei@debian.org>
5Uploaders: Matthias Albert <matthias@linux4experts.de>,6Uploaders: Matthias Albert <matthias@linux4experts.de>,
6Build-Depends: cdbs (>= 0.4.90~),7Build-Depends: cdbs (>= 0.4.90~),
7 debhelper (>= 7),8 debhelper (>= 7),
89
=== added file 'debian/glusterfs-server.mounting-glusterfs.upstart'
--- debian/glusterfs-server.mounting-glusterfs.upstart 1970-01-01 00:00:00 +0000
+++ debian/glusterfs-server.mounting-glusterfs.upstart 2012-01-29 12:55:28 +0000
@@ -0,0 +1,7 @@
1author "Louis Zuckerman <me@louiszuckerman.com>"
2description "Block the mounting event for glusterfs filesystems until glusterfs-server is running"
3
4start on mounting TYPE=glusterfs
5task
6exec start wait-for-state WAIT_FOR=glusterfs-server WAITER=mounting-glusterfs
7
08
=== added file 'debian/glusterfs-server.upstart'
--- debian/glusterfs-server.upstart 1970-01-01 00:00:00 +0000
+++ debian/glusterfs-server.upstart 2012-01-29 12:55:28 +0000
@@ -0,0 +1,10 @@
1author "Louis Zuckerman <me@louiszuckerman.com>"
2description "GlusterFS Management Daemon"
3
4start on runlevel [2345]
5stop on runlevel [016]
6
7expect fork
8
9exec /usr/sbin/glusterd -p /var/run/glusterd.pid
10
011
=== modified file 'debian/rules'
--- debian/rules 2011-06-26 21:00:42 +0000
+++ debian/rules 2012-01-29 12:55:28 +0000
@@ -24,6 +24,9 @@
24 rm -f debian/tmp/usr/lib/glusterfs/glusterfs/python/syncdaemon/*.pyc24 rm -f debian/tmp/usr/lib/glusterfs/glusterfs/python/syncdaemon/*.pyc
25 rm -f debian/tmp/usr/lib/glusterfs/glusterfs/python/syncdaemon/*.pyo25 rm -f debian/tmp/usr/lib/glusterfs/glusterfs/python/syncdaemon/*.pyo
2626
27binary-install/glusterfs-server::
28 dh_installinit -pglusterfs-server --upstart-only --no-start --name mounting-glusterfs
29
27clean::30clean::
28 dh $@31 dh $@
2932

Subscribers

People subscribed via source and target branches