Merge lp:~semiosis/ubuntu/precise/glusterfs/fix-for-876648 into lp:ubuntu/precise/glusterfs

Proposed by Louis Zuckerman
Status: Needs review
Proposed branch: lp:~semiosis/ubuntu/precise/glusterfs/fix-for-876648
Merge into: lp:ubuntu/precise/glusterfs
Diff against target: 68 lines (+29/-1)
5 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/glusterfs-server.mounting-glusterfs.upstart (+7/-0)
debian/glusterfs-server.upstart (+10/-0)
debian/rules (+3/-0)
To merge this branch: bzr merge lp:~semiosis/ubuntu/precise/glusterfs/fix-for-876648
Reviewer Review Type Date Requested Status
Clint Byrum (community) Needs Fixing
Review via email: mp+90587@code.launchpad.net

Description of the change

added two upstart jobs to glusterfs-server package:
- glusterfs-server.conf: the glusterd management daemon (replaces debian initscript)
- mounting-glusterfs.conf: blocks mounting glusterfs filesystems until glusterfs-server is started

To post a comment you must log in.
Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Wow this is great, thanks so much for submitting.

One nit-pick.. you need to run 'update-maintainer' in the package root so that the Maintainer is changed to the ubuntu developers, since we have patched the package. Just run that, and bzr commit/push, and it will be ready to be sponsored.

review: Needs Fixing
22. By Louis Zuckerman

updated maintaner to ubuntu developers

Revision history for this message
Louis Zuckerman (semiosis) wrote :

> Wow this is great, thanks so much for submitting.
>
> One nit-pick.. you need to run 'update-maintainer' in the package root so that
> the Maintainer is changed to the ubuntu developers, since we have patched the
> package. Just run that, and bzr commit/push, and it will be ready to be
> sponsored.

Done. I also fixed a typo in the mounting-glusterfs description.

23. By Louis Zuckerman

fixed a typo in the mounting-glusterfs description

Unmerged revisions

23. By Louis Zuckerman

fixed a typo in the mounting-glusterfs description

22. By Louis Zuckerman

updated maintaner to ubuntu developers

21. By Louis Zuckerman

Added Ubuntu upstart jobs providing support for local glusterfs mounts
(LP: #876648)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-01-07 14:19:57 +0000
3+++ debian/changelog 2012-01-29 12:55:28 +0000
4@@ -1,3 +1,10 @@
5+glusterfs (3.2.5-1ubuntu1) precise; urgency=low
6+
7+ * Added Ubuntu upstart jobs providing support for local glusterfs mounts
8+ (LP: #876648)
9+
10+ -- Louis Zuckerman <me@louiszuckerman.com> Sat, 28 Jan 2012 15:32:55 -0500
11+
12 glusterfs (3.2.5-1) unstable; urgency=low
13
14 [ Louis Zuckerman ]
15
16=== modified file 'debian/control'
17--- debian/control 2011-11-05 11:33:56 +0000
18+++ debian/control 2012-01-29 12:55:28 +0000
19@@ -1,7 +1,8 @@
20 Source: glusterfs
21 Section: admin
22 Priority: optional
23-Maintainer: Patrick Matthäi <pmatthaei@debian.org>
24+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
25+XSBC-Original-Maintainer: Patrick Matthäi <pmatthaei@debian.org>
26 Uploaders: Matthias Albert <matthias@linux4experts.de>,
27 Build-Depends: cdbs (>= 0.4.90~),
28 debhelper (>= 7),
29
30=== added file 'debian/glusterfs-server.mounting-glusterfs.upstart'
31--- debian/glusterfs-server.mounting-glusterfs.upstart 1970-01-01 00:00:00 +0000
32+++ debian/glusterfs-server.mounting-glusterfs.upstart 2012-01-29 12:55:28 +0000
33@@ -0,0 +1,7 @@
34+author "Louis Zuckerman <me@louiszuckerman.com>"
35+description "Block the mounting event for glusterfs filesystems until glusterfs-server is running"
36+
37+start on mounting TYPE=glusterfs
38+task
39+exec start wait-for-state WAIT_FOR=glusterfs-server WAITER=mounting-glusterfs
40+
41
42=== added file 'debian/glusterfs-server.upstart'
43--- debian/glusterfs-server.upstart 1970-01-01 00:00:00 +0000
44+++ debian/glusterfs-server.upstart 2012-01-29 12:55:28 +0000
45@@ -0,0 +1,10 @@
46+author "Louis Zuckerman <me@louiszuckerman.com>"
47+description "GlusterFS Management Daemon"
48+
49+start on runlevel [2345]
50+stop on runlevel [016]
51+
52+expect fork
53+
54+exec /usr/sbin/glusterd -p /var/run/glusterd.pid
55+
56
57=== modified file 'debian/rules'
58--- debian/rules 2011-06-26 21:00:42 +0000
59+++ debian/rules 2012-01-29 12:55:28 +0000
60@@ -24,6 +24,9 @@
61 rm -f debian/tmp/usr/lib/glusterfs/glusterfs/python/syncdaemon/*.pyc
62 rm -f debian/tmp/usr/lib/glusterfs/glusterfs/python/syncdaemon/*.pyo
63
64+binary-install/glusterfs-server::
65+ dh_installinit -pglusterfs-server --upstart-only --no-start --name mounting-glusterfs
66+
67 clean::
68 dh $@
69

Subscribers

People subscribed via source and target branches