Code review comment for lp:~seif/zeitgeist/fix-598666

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Unless there is a unit test to trigger/catch this issue I don't think it makes sense to add an extra check. In fact I think it's a bit hard to see if the patch would somehow introduce new weird corner case regressions.

So unless we understand the root cause (and have a test for it) of this bug I don't think we should merge this

review: Needs Fixing

« Back to merge proposal