Code review comment for lp:~seif/zeitgeist/add_cache_for_get_events
Revision history for this message
| Mikkel Kamstrup Erlandsen (kamstrup) wrote | # |
review:
Needs Information
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
I see you replaced the LRUCache implementation? Is this your own implementation, it doesn't look like your code style. I'm worried about licensing issues because you removed the LGPL header.
That said it makes a lot of sense to leverage the native collections module - so in principle I'm +1 for this approach.