Code review comment for lp:~seif/zeitgeist/add_cache_for_get_events
Revision history for this message
| Markus Korn (thekorn) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
35a32c5
(Get the code!)
Okidoki, seif. Can you please summarize and comment on the last change you did (against the last revision with this cache implementation). AFAICS you removed _current_id and reformated the docstrings, is this it?
Which bug in the old code were you actually fixing? is this fixing the KeyError you got several times?
Can you please write a test for the case this revision is fixing?
Thanks