Merge lp:~seif/zeitgeist-datasources/fix-telepathy-code-style into lp:zeitgeist-datasources/0.8

Proposed by Seif Lotfy
Status: Merged
Merged at revision: 99
Proposed branch: lp:~seif/zeitgeist-datasources/fix-telepathy-code-style
Merge into: lp:zeitgeist-datasources/0.8
Diff against target: 63 lines (+13/-6)
2 files modified
telepathy/org.freedesktop.Telepathy.Client.Zeitgeist.service (+1/-1)
telepathy/zeitgeist-telepathy-observer.py (+12/-5)
To merge this branch: bzr merge lp:~seif/zeitgeist-datasources/fix-telepathy-code-style
Reviewer Review Type Date Requested Status
Morten Mjelva Approve
Review via email: mp+42758@code.launchpad.net

Description of the change

fix code style breakage

To post a comment you must log in.
101. By Seif Lotfy

fixed line removal

102. By Seif Lotfy

fixed line removal

Revision history for this message
Morten Mjelva (mortenmjelva) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'telepathy/org.freedesktop.Telepathy.Client.Zeitgeist.service'
--- telepathy/org.freedesktop.Telepathy.Client.Zeitgeist.service 2010-11-08 15:48:49 +0000
+++ telepathy/org.freedesktop.Telepathy.Client.Zeitgeist.service 2010-12-04 22:23:08 +0000
@@ -1,3 +1,3 @@
1[D-BUS Service]1[D-BUS Service]
2Name=org.freedesktop.Telepathy.Client.Zeitgeist2Name=org.freedesktop.Telepathy.Client.Zeitgeist
3Exec=/home/mortenmj/Software/zeitgeist-dataproviders/telepathy/zeitgeist-telepathy-observer.py3Exec=/home/seif/Projects/zeitgeist-dataproviders/telepathy/zeitgeist-telepathy-observer.py
44
=== modified file 'telepathy/zeitgeist-telepathy-observer.py'
--- telepathy/zeitgeist-telepathy-observer.py 2010-11-08 15:48:49 +0000
+++ telepathy/zeitgeist-telepathy-observer.py 2010-12-04 22:23:08 +0000
@@ -160,6 +160,7 @@
160 except KeyError:160 except KeyError:
161 self._target_alias = self._target_id161 self._target_alias = self._target_id
162 162
163 self._connect_to_signals()
163 self._default_operations_finished()164 self._default_operations_finished()
164165
165 def _get_requested_cb(self, req):166 def _get_requested_cb(self, req):
@@ -188,15 +189,13 @@
188 # which depend on each other are executed in order.189 # which depend on each other are executed in order.
189 def _channel_ready(self, channel):190 def _channel_ready(self, channel):
190 self._target_id = self.properties[CHANNEL + '.TargetID']191 self._target_id = self.properties[CHANNEL + '.TargetID']
191192
192 # Get contact attribute interfaces193 # Get contact attribute interfaces
193 self[dbus.PROPERTIES_IFACE].Get(CHANNEL,194 self[dbus.PROPERTIES_IFACE].Get(CHANNEL,
194 'Requested',195 'Requested',
195 reply_handler=self._get_requested_cb,196 reply_handler=self._get_requested_cb,
196 error_handler=error)197 error_handler=error)
197198
198 self._connect_to_signals()
199
200 # This is necessary so our signal isn't sent over D-Bus199 # This is necessary so our signal isn't sent over D-Bus
201 def do_closed(self):200 def do_closed(self):
202 pass201 pass
@@ -228,7 +227,7 @@
228 if self._channel_requested:227 if self._channel_requested:
229 manifestation = unicode(Manifestation.USER_ACTIVITY)228 manifestation = unicode(Manifestation.USER_ACTIVITY)
230 else:229 else:
231 manifestation = unicode(Manifestation.WORLD_NOTIFICATION)230 manifestation = unicode(Manifestation.WORLD_ACTIVITY)
232231
233 timestamp = int(time() * 1000)232 timestamp = int(time() * 1000)
234233
@@ -271,7 +270,15 @@
271 def _message_received_cb(self, identification, timestamp, sender, contenttype,270 def _message_received_cb(self, identification, timestamp, sender, contenttype,
272 flags, content):271 flags, content):
273 logging.debug("Message received")272 logging.debug("Message received")
274273 if not self._subject:
274 self._subject = [Subject.new_for_values(
275 uri = self._target_id,
276 interpretation = unicode(Interpretation.IMMESSAGE),
277 manifestation = unicode(Manifestation.SOFTWARE_SERVICE),
278 origin = self.account_path,
279 mimetype = "text/plain",
280 text = self._target_alias)]
281
275 timestamp = timestamp * 1000282 timestamp = timestamp * 1000
276283
277 event = Event.new_for_values(284 event = Event.new_for_values(

Subscribers

People subscribed via source and target branches