Code review comment for lp:~seif/dockmanager/enhance-zeitgeist-menus

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

The menu_pressed method need some work. Now it will throw a exception in too many cases and if it fails it might not use the right application.
I think it is better to use:

if uri.endswith(".desktop"):
        appinfo = gio.unix.DesktopAppInfo(uri)
        if appinfo:
    except ...

review: Needs Fixing

« Back to merge proposal